feat: legend component for standings table#7477
Open
ElectricalBoy wants to merge 23 commits intomainfrom
Open
Conversation
ElectricalBoy
changed the title
ElectricalBoy
force-pushed
the
legend-widget
branch
from
318d8ed to
0661b78
Compare
hjpalpha
reviewed
May 9, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
do we want/need to adress the dq case?
|
|
||
| GoldenTest('standings_legend', tostring(LegendComponent{ | ||
| color = { | ||
| byeup = 'Lorem ipsum', |
Collaborator
There was a problem hiding this comment.
maybe to make sure no one adds a bad mapping
Suggested change
| byeup = 'Lorem ipsum', | |
| byeup = 'Lorem ipsum byeup', |
(analogous for others)
Collaborator
Author
eventually yes, but I would rather do it when we add dq color definitions to stylesheets (that would be a separate pr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the legend component for standings tables.
How did you test this change?
sandbox + browser dev tools